Annotate .status.conditions as map-list #226
Conversation
This allows server-side apply to update conditions individually. Sadly, it must be applied manually for each CRD to take effect.
Depends on stackabletech/operator-rs#226, merge that before this.
|
Only on my phone: We used to have this and removed it when k8s-openapi introduced the schemas. Does this mean this should really be upstream? |
|
I'll look into it, but sadly I don't /think/ schemars allows this kind of customization on the type level without opting out of the derive macro completely. |
|
Yep.. GREsau/schemars#50 |
|
Okay, good point. Thanks. |
|
Okay, so this isn't actually required anyway it seems, since k8s-openapi does its own schema codegen without relying on the derive... |
|
Oh right, we can't even override that generically anyway, since we don't have any generic way to control The only way to get around that would be to define our own |
Because stackabletech/operator-rs#226 was merged
* Fix .status.conditions schema Depends on stackabletech/operator-rs#226, merge that before this. * Add to changelog * Switch back to operator-rs#main Because stackabletech/operator-rs#226 was merged
Description
This allows server-side apply to update conditions individually. Sadly, it must be applied manually for each CRD crate to take effect.
Requires #225 in order for operators not to misuse SSA to trample all over each others'
conditionsanyway.Review Checklist