Upgrade Clap to 3.0.4 #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhennig
reviewed
Jan 10, 2022
| //! name = "Spark Operator", | ||
| //! author, | ||
| //! version, | ||
| //! about = "Stackable Operator for Foobar" |
There was a problem hiding this comment.
"Stackable Operator for Spark"
There was a problem hiding this comment.
Switched the remaining names to "Foobar Operator".
| //! name = "Spark Operator", | ||
| //! author, | ||
| //! version, | ||
| //! about = "Stackable Operator for Foobar" |
There was a problem hiding this comment.
Switched the remaining names to "Foobar Operator".
| @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| - BREAKING: clap 2.33.3 -> 3.0.4 ([#289]). | |||
There was a problem hiding this comment.
Are there any breaking changes in how the operator is used now?
There was a problem hiding this comment.
Users need to replace their clap 2 and structopt dependencies with clap 3, and replace references to structopt::StructOpt with clap::Parser.
4 tasks
soenkeliebau
approved these changes
Jan 13, 2022
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jan 17, 2022
291: Allow overriding CLI run arg type r=teozkr a=teozkr ## Description This is useful for secret-operator, which doesn't have a product-config but does care about other options, such as the CSI plugin socket path. This depends on and builds upon #289. ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This requires some manual work (compared to #288), since Clap is a breaking update. In particular,
structopt::StructOpthas now been upstreamed asclap::Parser.Review Checklist