PodBuilder can now set pod affinity #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you very much for your contribution! I've just kicked off a CI run. |
|
This is a useful addition that's been on our backburner anyway, thanks! I'd be happy to merge this once the CI errors are sorted out. |
…affinity on PodSpec
…nity when constructing Affinity with only pod_affinity
|
thanks! Please let me know if this looks good enough, it may get uglier down the line when anti-affinity is added |
|
Hi @andlaz, unfortunately there are still some clippy & rustfmt issues. |
|
yes, thanks, let me have a quick look |
|
Thank you, there's only one rustfmt issue left :) |
|
Thank you @andlaz, ill go ahead and merge |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review Checklist