-
-
Notifications
You must be signed in to change notification settings - Fork 15
[Merged by Bors] - Add support for secret-operator volumes to pod volume builder #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot!
|
Sort of.. the question there would be how much we want to validate in the operator vs just passing it through. We might also want to force certain scopes when we know that a service will require them.. not sure there. |
Alright, i will think of a solution |
I will also add some unit test as I'm working on new features for |
Kinda getting mixed signals here... :P |
I'm happy to merge this as is. I'm working on the "passing a scope string to SecretOperatorVolumeSourceBuilder" but will open a separate PR for that. |
Alright. bors r+ |
## Description ## Review Checklist - [x] Code contains useful comments - [x] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Pull request successfully merged into main. Build succeeded: |
Description
Review Checklist