Skip to content

[Merged by Bors] - Upgrade to kube-rs 0.75.0 (Api-Less Edition(TM)) #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Upgrade to kube-rs 0.75.0 (Api-Less Edition(TM)) #490

wants to merge 6 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 13, 2022 •
edited by siegfriedweber
Loading

Description

This is an alternate take on #481/#471 that does not introduce a new operator-framework-level Api type. Instead, it introduces a new GetApi trait that lets Client::get_api specialize as needed.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr
Upgrade to kube-rs 0.75.0
77e23ac 
This is an alternate take on #481/#471 that does not introduce a new
operator-framework-level `Api` type. Instead, it introduces a new `GetApi`
trait that lets `Client::get_api` specialize as needed.
@nightkr nightkr linked an issue Oct 13, 2022 that may be closed by this pull request
Upgrade to kube-rs 0.75.0 #471
Closed
2 tasks
siegfriedweber
siegfriedweber requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your approach.

The doc test must be fixed and a changelog entry is missing.

@nightkr
Copy link
Member Author

nightkr commented Oct 17, 2022

@siegfriedweber I believe I've addressed all your concerns now.

siegfriedweber
siegfriedweber requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have only two tiny remarks again.

nightkr and others added 2 commits October 17, 2022 15:33
@nightkr @siegfriedweber
Update CHANGELOG.md
24fe6d7 
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@nightkr @siegfriedweber
Update src/cluster_resources.rs
92f93e9 
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@nightkr
Copy link
Member Author

nightkr commented Oct 17, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 17, 2022
@nightkr
Upgrade to kube-rs 0.75.0 (Api-Less Edition(TM)) (#490)
c62bdb8 
## Description

This is an alternate take on #481/#471 that does not introduce a new operator-framework-level `Api` type. Instead, it introduces a new `GetApi` trait that lets `Client::get_api` specialize as needed.



Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
This was referenced Oct 17, 2022
Closed
Closed
@bors
Copy link
Contributor

bors bot commented Oct 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Upgrade to kube-rs 0.75.0 (Api-Less Edition(TM)) [Merged by Bors] - Upgrade to kube-rs 0.75.0 (Api-Less Edition(TM)) Oct 17, 2022
@bors bors bot closed this Oct 17, 2022
@bors bors bot deleted the feature/kube-0.75.0-no-api branch October 17, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to kube-rs 0.75.0
2 participants
@nightkr @siegfriedweber