Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Bump kube to 0.78.0 and k8s-openapi to 0.17.0. Bump k8s version #533

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Bump kube to 0.78.0 and k8s-openapi to 0.17.0. Bump k8s version #533

wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from a team January 12, 2023 07:33
@sbernauer sbernauer self-assigned this Jan 12, 2023
maltesander
maltesander approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, one minor thing.

src/builder/pod/container.rs Outdated Show resolved Hide resolved
maltesander
maltesander reviewed Jan 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sbernauer and others added 2 commits January 12, 2023 09:21
@sbernauer @maltesander
Update src/builder/pod/container.rs
f52c8d1 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer @maltesander
Update CHANGELOG.md
386da33 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer sbernauer requested a review from maltesander January 12, 2023 08:21
@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 12, 2023
@sbernauer
Bump kube to 0.78.0 and k8s-openapi to 0.17.0. Bump k8s version (#533)
404b295
@bors
Copy link
Contributor

bors bot commented Jan 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Bump kube to 0.78.0 and k8s-openapi to 0.17.0. Bump k8s version [Merged by Bors] - Bump kube to 0.78.0 and k8s-openapi to 0.17.0. Bump k8s version Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
@bors bors bot deleted the k8s-1.26 branch January 12, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander Awaiting requested review from maltesander

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander