Skip to content

[Merged by Bors] - Add building of rbac resources #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Mar 27, 2023

Description

Add a helper function to build rbac resources.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 marked this pull request as ready for review March 27, 2023 20:20
@adwk67 adwk67 requested a review from a team March 27, 2023 20:20
@adwk67 adwk67 self-assigned this Mar 28, 2023
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this PR only extracts code that is already used "in production" into operator-rs

@adwk67
Copy link
Member Author

adwk67 commented Mar 28, 2023

I assume this PR only extracts code that is already used "in production" into operator-rs

Yes, correct. We already have it in airflow, hbase, spark-k8s etc. I'll replace those with references to this function in subsequent PRs.

@adwk67
Copy link
Member Author

adwk67 commented Mar 28, 2023

bors merge

bors bot pushed a commit that referenced this pull request Mar 28, 2023
## Description

Add a helper function to build rbac resources.
@bors
Copy link
Contributor

bors bot commented Mar 28, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add building of rbac resources [Merged by Bors] - Add building of rbac resources Mar 28, 2023
@bors bors bot closed this Mar 28, 2023
@bors bors bot deleted the openshift-rbac branch March 28, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants