Skip to content

[Merged by Bors] - Update to kube-rs 0.82.2 and dependencies #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Apr 19, 2023

Description

fixes #588

updated dependencies:

  • kube-rs 0.82.2
  • k8s-openapi 0.18.0
  • json_patch 1.0.0
  • rstest 0.17.0

other:

  • derive defaults for some enums instead of impl (clippy)

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander changed the title Update kubers and dependencies Update to kube-rs 0.82.2 and dependencies Apr 19, 2023
@maltesander maltesander requested a review from a team April 19, 2023 11:52
@maltesander maltesander self-assigned this Apr 19, 2023
@maltesander maltesander added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. type/dependencies Pull requests that update a dependency file and removed release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Apr 19, 2023
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and I'll approve but maybe someone else, closer to the code, wants to take a look as well.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Apr 20, 2023
## Description

fixes #588

updated dependencies:
- kube-rs 0.82.2
- k8s-openapi 0.18.0
- json_patch 1.0.0
- rstest 0.17.0

other:
- derive defaults for some enums instead of impl (clippy)



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 20, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update to kube-rs 0.82.2 and dependencies [Merged by Bors] - Update to kube-rs 0.82.2 and dependencies Apr 20, 2023
@bors bors bot closed this Apr 20, 2023
@bors bors bot deleted the update-kube-rs-and-dependecies branch April 20, 2023 07:19
Techassi added a commit that referenced this pull request Jun 5, 2023
This commit includes multiple changes suggested in the PR #589 like:

- Rename `ResourceRequirementsPolicy` to `ResourceRequirementType`.
  This also includes the associated error and trait.
- Removing the ResourceRequirementType::Claims variant as we currently
  do not supoort it. This can be re-added in the future.
- Add `with_resource`, `with_cpu` and `with_memory` methods to the
  container builder. This allows setting limits and requests for
  resources explicitly and in a controlled manner.
- Removed `resources` method from container builder. This method
  is replaced by the new methods mentioned above.
- Update CHANGELOG

A follow-up commit will use the newly added methods from above in
the `PodBuilder`s `add_init_container` method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to kube-rs 0.82.2
3 participants