-
-
Notifications
You must be signed in to change notification settings - Fork 15
[Merged by Bors] - Update to kube-rs 0.82.2 and dependencies #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me and I'll approve but maybe someone else, closer to the code, wants to take a look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bors merge |
## Description fixes #588 updated dependencies: - kube-rs 0.82.2 - k8s-openapi 0.18.0 - json_patch 1.0.0 - rstest 0.17.0 other: - derive defaults for some enums instead of impl (clippy) Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Pull request successfully merged into main. Build succeeded: |
This commit includes multiple changes suggested in the PR #589 like: - Rename `ResourceRequirementsPolicy` to `ResourceRequirementType`. This also includes the associated error and trait. - Removing the ResourceRequirementType::Claims variant as we currently do not supoort it. This can be re-added in the future. - Add `with_resource`, `with_cpu` and `with_memory` methods to the container builder. This allows setting limits and requests for resources explicitly and in a controlled manner. - Removed `resources` method from container builder. This method is replaced by the new methods mentioned above. - Update CHANGELOG A follow-up commit will use the newly added methods from above in the `PodBuilder`s `add_init_container` method.
Description
fixes #588
updated dependencies:
other:
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information