Skip to content

[Merged by Bors] - Allow users to request a secret format #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 22, 2023

Description

The client side of stackabletech/secret-operator#286

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested review from lfrancke and a team and removed request for lfrancke June 22, 2023 09:58
@lfrancke
Copy link
Member

FYI: There is still a conflict in this branch

@nightkr
Copy link
Member Author

nightkr commented Jun 22, 2023

Yeah I know, I branched off of 0.41.0 to keep the changes in zk-op more focused on what's required for this specifically.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % @Techassi comment on strum

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr
Copy link
Member Author

nightkr commented Jun 28, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 28, 2023

## Description

The client side of stackabletech/secret-operator#286



Co-authored-by: Natalie Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Natalie <teo@nullable.se>
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Allow users to request a secret format [Merged by Bors] - Allow users to request a secret format Jun 28, 2023
@bors bors bot closed this Jun 28, 2023
@bors bors bot deleted the feature/secret-format branch June 28, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants