Skip to content

fix: Docker image tag parsing when user specifies custom image #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2023
Merged

fix: Docker image tag parsing when user specifies custom image #677

merged 5 commits into from
Oct 31, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 20, 2023 •
edited by lfrancke
Loading

Description

Fixes the problem reported in Slack by @Jimvin

For info, the thing that triggered this error for us was using a custom image from a local docker repo which had the port number in the url. I am assuming that it tried to parse everything after the first : character using SemVer, but the error isn’t all that helpful in pointing out what was being parsed.
This seems to be a bug in the parsing of custom image locations with port numbers in the location.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer self-assigned this Oct 20, 2023
soenkeliebau added a commit to stackabletech/hdfs-opa-authorizer that referenced this pull request Oct 30, 2023
@soenkeliebau
Serialization issues due to UGI throwing an exception when jackson wa…
0f6ea31 
…nts to use the getter for primaryGroup and there is no primary group.

Tilt not working yet due to
 - loading into kind fails because of pullstrategy: always and the image not being in a repo
 - local repo fails due to stackabletech/operator-rs#677
@sbernauer sbernauer enabled auto-merge October 31, 2023 10:29
soenkeliebau
soenkeliebau approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the code and tested the changes locally.
Works as intended. Not aure if this is the final form of image parsing, bit fixes an issue.

@sbernauer sbernauer added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 496baab Oct 31, 2023
@sbernauer sbernauer deleted the fix/docker-tag-parsing branch October 31, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soenkeliebau soenkeliebau soenkeliebau approved these changes

@Techassi Techassi Awaiting requested review from Techassi

@lfrancke lfrancke Awaiting requested review from lfrancke

Assignees

@sbernauer sbernauer

Labels
release/23.11.0 type/bug
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbernauer @lfrancke @soenkeliebau @Techassi