Skip to content

Replace docs URL placeholder with versioned docs link in CRD output #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 4, 2023
Merged

Replace docs URL placeholder with versioned docs link in CRD output #689

merged 8 commits into from
Dec 4, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Nov 30, 2023 •
edited
Loading

Description

This is a breaking change.

To fix main.rs in the operator, change the CRD generation like so:

Command::Crd => DruidCluster::print_yaml_schema(built_info::CARGO_PKG_VERSION)?,

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

github-actions[bot]
github-actions bot reviewed Nov 30, 2023
View reviewed changes
@fhennig fhennig marked this pull request as ready for review November 30, 2023 11:02
sbernauer
sbernauer requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, only some nit-pcking

sbernauer
sbernauer reviewed Nov 30, 2023
View reviewed changes
fhennig and others added 3 commits November 30, 2023 12:52
@fhennig @sbernauer
Update src/crd.rs
c2e5147 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
use semver
668a2a8
cargo fmt
07fb5a4
@fhennig fhennig enabled auto-merge November 30, 2023 12:20
@fhennig fhennig disabled auto-merge November 30, 2023 12:21
sbernauer
sbernauer approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig fhennig added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 39dbfa7 Dec 4, 2023
@fhennig fhennig deleted the feat/crd-versioned-docs-links branch December 4, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @sbernauer