Skip to content

chore: Release stackable-operator 0.69.0 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jun 3, 2024

Release stackable-operator 0.68.1 which includes these changes:

  • Add functionality to convert LogLevel to an OPA log level (#798).
  • Add labels to listener volume builder (#799).

@Techassi Techassi self-assigned this Jun 3, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use 0.69.0 as there are new features and especially a breaking change in this.

Please also mark #799 as BREAKING in the changelog.

@Techassi
Copy link
Member Author

Techassi commented Jun 3, 2024

I wouldn't classify adding labels to PVCs a breaking change. If it is breaking, it should've been marked as such in the original PR (#799).

@sbernauer
Copy link
Member

sbernauer commented Jun 3, 2024

It was missed in the PR and I wasn't quick enough to review :)

I would use something like

- BREAKING: Add labels to listener volume builder. `PodBuilder::add_listener_volume_by_listener_class`, `PodBuilder::add_listener_volume_by_listener_name` and `ListenerOperatorVolumeSourceBuilder::new` now require you to pass the labels for the created volumes ([#799]).

@Techassi
Copy link
Member Author

Techassi commented Jun 3, 2024

Ah well, another instance where manually maintaining the changelog file caused an issue. I guess we consider the changes as breaking because we altered the API. It shouldn't be breaking from a functionality point-of-view.

I will adjust the changelog and the version.


It might be worth to differentiate between these two instances. Should we open a decision / discussion for that?

@Techassi Techassi requested a review from sbernauer June 3, 2024 11:38
@sbernauer
Copy link
Member

Ah well, another instance where manually maintaining the changelog file caused an issue.

The label changelog/breaking was also missing, I don't see how automation could have prevented that 🙈
Maybe there is a tool out there that automatically detects breaking changes, but that might be an overkill for our small lib with mostly only us as users.

Should we open decision / discussion for that?

Would be great, but I'm personally happy as is, given our limited time resources. For me it's important to state why this change is breaking, than users can decide on there own if they care or not

@Techassi Techassi changed the title chore: Release stackable-operator 0.68.1 chore: Release stackable-operator 0.69.0 Jun 3, 2024
@Techassi Techassi added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 9ff61fa Jun 3, 2024
17 checks passed
@Techassi Techassi deleted the chore/release-stackable-operator-0.68.1 branch June 3, 2024 11:54
@Techassi
Copy link
Member Author

Techassi commented Jun 3, 2024

I don't see how automation could have prevented that

Using conventional commits could solve that. It uses ! to indicate when a change is breaking. That obviously would require that developers don't forget to use it :)

Maybe there is a tool out there that automatically detects breaking changes

There actually is, see https://github.com/obi1kenobi/cargo-semver-checks

Would be great

Alright, I will create one in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants