-
-
Notifications
You must be signed in to change notification settings - Fork 15
chore: Release stackable-operator 0.69.0 #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use 0.69.0 as there are new features and especially a breaking change in this.
Please also mark #799 as BREAKING in the changelog.
I wouldn't classify adding labels to PVCs a breaking change. If it is breaking, it should've been marked as such in the original PR (#799). |
It was missed in the PR and I wasn't quick enough to review :) I would use something like
|
Ah well, another instance where manually maintaining the changelog file caused an issue. I guess we consider the changes as breaking because we altered the API. It shouldn't be breaking from a functionality point-of-view. I will adjust the changelog and the version. It might be worth to differentiate between these two instances. Should we open a decision / discussion for that? |
The label
Would be great, but I'm personally happy as is, given our limited time resources. For me it's important to state why this change is breaking, than users can decide on there own if they care or not |
Using conventional commits could solve that. It uses
There actually is, see https://github.com/obi1kenobi/cargo-semver-checks
Alright, I will create one in the next couple of days. |
Release stackable-operator 0.68.1 which includes these changes: