Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add TLS cert lifetime setter to SecretOperatorVolumeSourceBuilder #915

Merged
merged 8 commits into from
Dec 2, 2024
Merged

feat: Add TLS cert lifetime setter to SecretOperatorVolumeSourceBuilder #915

merged 8 commits into from
Dec 2, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Nov 27, 2024

Description

Part of: stackabletech/issues#586

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@razvan razvan requested a review from a team November 27, 2024 17:15
@razvan razvan mentioned this pull request Nov 27, 2024
Closed
sbernauer
sbernauer previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Can we please rename the PR to something like feat: Add TLS cert lifetime setter to SecretOperatorVolumeSourceBuilder

@razvan razvan changed the title feat: make autotls cert lifetime configurable feat: Add TLS cert lifetime setter to SecretOperatorVolumeSourceBuilder Nov 28, 2024
@razvan razvan enabled auto-merge November 28, 2024 10:35
@razvan razvan requested a review from sbernauer November 28, 2024 10:35
This was referenced Nov 28, 2024
Merged
Merged
NickLarsenNZ
NickLarsenNZ previously requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a fixed up changelog

crates/stackable-operator/CHANGELOG.md Outdated Show resolved Hide resolved
sbernauer
sbernauer approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@razvan razvan mentioned this pull request Nov 29, 2024
Merged
@sbernauer sbernauer dismissed NickLarsenNZ’s stale review December 2, 2024 08:08

Changelog updated

@razvan razvan added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 7939b35 Dec 2, 2024
8 of 10 checks passed
@razvan razvan deleted the feat/request-secret-lifetime branch December 2, 2024 08:14
@Techassi Techassi mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees

@razvan razvan

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvan @NickLarsenNZ @sbernauer