Skip to content

ci: add nix install action #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2024
Merged

ci: add nix install action #327

merged 1 commit into from
Feb 22, 2024

Conversation

NickLarsenNZ
Copy link
Member

The operator builds fail when they run make -e publish which calls the build make target, which then calls regenerate-nix target.

@nightkr do we want the build to be regenerating-nix? Is it possible that the builds don't then use the versions/hashes in the committed lockfiles?

@NickLarsenNZ NickLarsenNZ requested a review from nightkr February 21, 2024 18:54
NickLarsenNZ added a commit to stackabletech/airflow-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
7b79550
NickLarsenNZ added a commit to stackabletech/druid-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
b624cd2
NickLarsenNZ added a commit to stackabletech/hbase-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
6c5e29e
NickLarsenNZ added a commit to stackabletech/hdfs-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
d5a1785
NickLarsenNZ added a commit to stackabletech/hive-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
8e8865d
NickLarsenNZ added a commit to stackabletech/kafka-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
0d9c729
NickLarsenNZ added a commit to stackabletech/nifi-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
798f280
NickLarsenNZ added a commit to stackabletech/spark-k8s-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
507d889
NickLarsenNZ added a commit to stackabletech/superset-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
4327494
NickLarsenNZ added a commit to stackabletech/trino-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
3cedcd9
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
36449b1
NickLarsenNZ added a commit to stackabletech/commons-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
4967880
NickLarsenNZ added a commit to stackabletech/listener-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
69769a4
NickLarsenNZ added a commit to stackabletech/opa-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
6d50e40
NickLarsenNZ added a commit to stackabletech/secret-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
81e8913
NickLarsenNZ added a commit to stackabletech/edc-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
68ab47e
NickLarsenNZ added a commit to stackabletech/hello-world-operator that referenced this pull request Feb 21, 2024
@NickLarsenNZ
ci: add nix action (stackabletech/operator-templating#327)
533f37c
@NickLarsenNZ NickLarsenNZ self-assigned this Feb 22, 2024
github-merge-queue bot pushed a commit to stackabletech/airflow-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#388)
bbe9475 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/hbase-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#456)
8c18d70 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/hdfs-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#476)
389fba6 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/hive-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#417)
dbb71da 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/kafka-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#665)
15b612a 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/nifi-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#575)
4b4b442 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/spark-k8s-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#360)
fdbc4bf 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/superset-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#458)
5096ce7 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/trino-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#540)
8e5d689 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/zookeeper-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#773)
bbe668f 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/commons-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#213)
b4d43df 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/listener-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#150)
7ef8ae3 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/opa-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#527)
6611e89 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/secret-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#373)
3da3c37 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/edc-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#56)
83f12bc 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/hello-world-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#55)
9b9b93f 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
github-merge-queue bot pushed a commit to stackabletech/druid-operator that referenced this pull request Feb 22, 2024
@stackable-bot @NickLarsenNZ
Update templated files to rev a30e98e (#519)
482f7ed 
* Generated commit to update templated files based on rev a30e98e in stackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: NickLarsenNZ with message [Support for nix-shell]

* ci: add nix action (stackabletech/operator-templating#327)

* add niv dependencies

---------

Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
sbernauer
sbernauer approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as otherwise the build is broken. We can always improve things later on :)

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 752a805 Feb 22, 2024
@NickLarsenNZ NickLarsenNZ deleted the template/ci-nix-command branch February 22, 2024 08:01
@NickLarsenNZ
Copy link
Member Author

@lfrancke I'll leave this in Waiting for Review to give @nightkr a chance to see my comment in the description (which could lead to a future PR).

If you prefer me to raise an issue so we can move this off the board, let me know 👍

@nightkr
Copy link
Member

nightkr commented Feb 22, 2024

@nightkr do we want the build to be regenerating-nix? Is it possible that the builds don't then use the versions/hashes in the committed lockfiles?

crate2nix should respect the Cargo.lock. If anything I'd want CI to fail if regenerate-nix isn't a no-op.

@NickLarsenNZ
Copy link
Member Author

crate2nix should respect the Cargo.lock. If anything I'd want CI to fail if regenerate-nix isn't a no-op.

Ok cool. So the crate2nix and niv lockfile updates are still manually managed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@nightkr nightkr Awaiting requested review from nightkr

@dervoeti dervoeti Awaiting requested review from dervoeti

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickLarsenNZ @nightkr @sbernauer