Dockerfile updates #432
Merged
Dockerfile updates #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also uses OpenContainer annotations as in our product images - Switches to a different user id for security reasons
|
Pre-commit is wrong. The generated Dockerfiles look good to me. |
It's the wrong hadolint version. It should be 2.12.0 |
|
Yes, I updated it in #435 |
|
Okay...this is ready for review again. The remaining hadolint warning is not a new one and occurs due to the Jinja syntax in the Dockerfile template |
sbernauer
reviewed
Sep 16, 2024
|
Thank you. I just need to resolve the conflicts. |
# Conflicts: # template/docker/Dockerfile.j2
sbernauer
approved these changes
Sep 17, 2024
|
Unfortunately, this has a bug. It references an argument |
lfrancke
added a commit
that referenced
this pull request
Sep 18, 2024
This fixes an issue introduced by a past PR (#432). It uses an argument that doesn't exist ("STACKABLE_USER_NAME"). In the course of diagnosing that I stumbled across a few inconsistencies with our "docker-images" Dockerfiles which I am addressing here as well. - Updates the Helm version used (not caught by Renovate yet) - Sets a build timeout for the build & package phase to two hours (down from the default of 6) - Adds the dnf.conf file - Adds convenience utilities - Adds a few common aliases and a better prompt
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Fix broken Dockerfile and minor improvements This fixes an issue introduced by a past PR (#432). It uses an argument that doesn't exist ("STACKABLE_USER_NAME"). In the course of diagnosing that I stumbled across a few inconsistencies with our "docker-images" Dockerfiles which I am addressing here as well. - Updates the Helm version used (not caught by Renovate yet) - Sets a build timeout for the build & package phase to two hours (down from the default of 6) - Adds the dnf.conf file - Adds convenience utilities - Adds a few common aliases and a better prompt * Add a small README
lfrancke
added
release-note
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes