Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Various template fixes #436

Merged
merged 5 commits into from
Sep 17, 2024
Merged

chore: Various template fixes #436

merged 5 commits into from
Sep 17, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Sep 16, 2024

Non-template Changes:

  • Split the reason text into author and reason.
    This reduces notification noise for the author, as before they were receiving notifications for both the PR and the commit which contained the reason text.
  • Assign the generated PRs to the author instead of stackabletech/Developers.
    This reduces notification noise for the team when it is likely that the author will be merging the changes.
  • pre-commit/actionlint: Move the actionlint config to the correct location, and check templated files too.

Template changes (to be rolled out):

  • pre-commit/actionlint: Move the actionlint config to the correct location.
  • pre-commit/workflow: Checkout git submodules.
    Needed for listener and secret operators.
  • pre-commit/workflow: Install nix.
    Needed for running cargo commands via nix-shell
  • pre-commit: Run cargo commands via nix-shell.
    This ensures the necessary dependencies are there.
  • Fix lint issues that now appear.

Related PRs

…o the author.

- Stops the author being notified for both the PR and the commit.
- Assign the PR to the author instead of the stackabletech/Developers group to reduce notification noise.
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit a16c534 Sep 17, 2024
2 checks passed
@NickLarsenNZ NickLarsenNZ deleted the various-template-fixes branch September 17, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants