Skip to content

Conversation

@Techassi
Copy link
Member

@Techassi Techassi commented Oct 22, 2025

Closes #626.

Note

A bug fix was needed for this: stackabletech/operator-rs#1109

This PR marks the cert-manager backend es non-experimental by renaming the CRD field from experimentalCertManager to certManager.

@Techassi Techassi self-assigned this Oct 22, 2025
@Techassi Techassi added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/25.11.0 labels Oct 22, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering Oct 22, 2025
@Techassi Techassi force-pushed the feat/mark-cert-manager-as-non-experimental branch from 78f88c2 to fd52273 Compare October 23, 2025 14:53
@Techassi Techassi force-pushed the feat/mark-cert-manager-as-non-experimental branch from fd52273 to eab4d61 Compare October 23, 2025 15:01
@Techassi Techassi marked this pull request as ready for review October 23, 2025 15:22
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 23, 2025
@Techassi
Copy link
Member Author

Release Note

==== Platform improvements

===== Stackable secret-operator

*Breaking:* The `certManager` backend is no longer experimental.
In version `v1alpha2` of the SecretClass, the `experimentalCertManager` field was renamed to `certManager`.
See the xref:secret-operator:secretclass.adoc[SecretClass reference] for more details.

@adwk67 adwk67 self-requested a review October 24, 2025 12:38
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 24, 2025
@sbernauer
Copy link
Member

Ah you beat me by literally a minute :D

@Techassi
Copy link
Member Author

Ah you beat me by literally a minute :D

There is always the option to have more than one reviewer :)

@sbernauer
Copy link
Member

I let @adwk67 review, just two leftovers I noticed:

diff --git a/docs/modules/secret-operator/pages/cert-manager.adoc b/docs/modules/secret-operator/pages/cert-manager.adoc
index aa88c1c..50774d2 100644
--- a/docs/modules/secret-operator/pages/cert-manager.adoc
+++ b/docs/modules/secret-operator/pages/cert-manager.adoc
@@ -43,7 +43,7 @@ include::example$cert-manager/issuer.yaml[]
 == Creating a SecretClass
 
 The Stackable Secret Operator needs to know how to request the certificates from Cert-Manager.
-Do this by creating a xref:secretclass.adoc[] using the xref:secretclass.adoc#backend-certmanager[`experimentalCertManager` backend].
+Do this by creating a xref:secretclass.adoc[] using the xref:secretclass.adoc#backend-certmanager[`certManager` backend].
 
 [source,yaml]
 ----
diff --git a/rust/operator-binary/src/crd/secret_class/mod.rs b/rust/operator-binary/src/crd/secret_class/mod.rs
index 068451e..89ce09d 100644
--- a/rust/operator-binary/src/crd/secret_class/mod.rs
+++ b/rust/operator-binary/src/crd/secret_class/mod.rs
@@ -53,8 +53,8 @@ pub mod versioned {
         /// A new certificate and key pair will be generated and signed for each Pod, keys or certificates are never reused.
         AutoTls(AutoTlsBackend),
 
-        /// The [`experimentalCertManager` backend][1] injects a TLS certificate issued
-        /// by [cert-manager](https://cert-manager.io/).
+        /// The [`certManager` backend][1] injects a TLS certificate issued by
+        /// [cert-manager](https://cert-manager.io/).
         ///
         /// A new certificate will be requested the first time it is used by a Pod, it
         /// will be reused after that (subject to cert-manager renewal rules).

@Techassi
Copy link
Member Author

Techassi commented Oct 24, 2025

I let @adwk67 review, just two leftovers I noticed:

Ah, nice spotting! I will adjust it asap. Adjusted in 08eaa31.

@sbernauer
Copy link
Member

Just for the record @adwk67: We intentional left tests and stuff on v1alpha1 to actually test the conversions

adwk67
adwk67 previously approved these changes Oct 24, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Openshift - LGTM!

@Techassi Techassi added this pull request to the merge queue Oct 24, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Oct 24, 2025
@Techassi Techassi removed this pull request from the merge queue due to a manual request Oct 24, 2025
@Techassi Techassi moved this from Development: Done to Development: In Review in Stackable Engineering Oct 24, 2025
@Techassi Techassi added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 6639bb8 Oct 24, 2025
17 checks passed
@Techassi Techassi deleted the feat/mark-cert-manager-as-non-experimental branch October 24, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/25.11.0

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

Mark cert-manager backend as non-experimental

3 participants