Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bump operator-rs to 0.27.1 #178

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - bump operator-rs to 0.27.1 #178

wants to merge 7 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Nov 21, 2022 •
edited
Loading

Description

Bump operator-rs and refactor.
Fixes #172.
🟢 CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/47/ (updated)

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 marked this pull request as ready for review November 21, 2022 12:50
@adwk67 adwk67 requested a review from a team November 21, 2022 12:55
@razvan razvan requested review from razvan and removed request for a team November 21, 2022 12:59
razvan
razvan reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
adwk67 and others added 2 commits November 21, 2022 14:52
@adwk67 @razvan
Update rust/crd/src/lib.rs
2f7c1ac 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@adwk67
changes following review
489a864
razvan
razvan approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@adwk67 adwk67 requested a review from razvan November 22, 2022 13:56
@adwk67
Copy link
Member Author

adwk67 commented Nov 22, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 22, 2022
@adwk67
bump operator-rs to 0.27.1 (#178)
b530bbc 
# Description

Bump operator-rs and refactor.
Fixes #172.
:green_circle: CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/47/ (updated)
@bors
Copy link

bors bot commented Nov 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bump operator-rs to 0.27.1 [Merged by Bors] - bump operator-rs to 0.27.1 Nov 22, 2022
@bors bors bot closed this Nov 22, 2022
@bors bors bot deleted the bump-op-rs-027 branch November 22, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan Awaiting requested review from razvan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump operator-rs to 0.27.1
2 participants
@adwk67 @razvan