Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Merging and validation of the configuration refactored #223

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - Merging and validation of the configuration refactored #223

wants to merge 13 commits into from

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Mar 30, 2023 •
edited
Loading

Description

Merging and validation of the configuration refactored

Prerequisite for #218

Integration tests

Extensively tested due to flakiness:

Platform Test run Result
Azure AKS 1.26.0 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/74/ ✔
Azure AKS 1.25 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/75/ ✔
Google GKE 1.26 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/76/ ✔
Google GKE 1.25 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/77/ ✔
AWS EKS 1.25 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/78/ ✔
IONOS K8s 1.25.6 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/79/ ✔

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber self-assigned this Mar 30, 2023
maltesander
maltesander reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests succeed (i think there were 3 failures).

rust/crd/src/lib.rs Show resolved Hide resolved
maltesander
maltesander approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@siegfriedweber
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 31, 2023
@siegfriedweber
Merging and validation of the configuration refactored (#223)
2113e1c 
# Description

Merging and validation of the configuration refactored
@bors
Copy link

bors bot commented Mar 31, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Merging and validation of the configuration refactored [Merged by Bors] - Merging and validation of the configuration refactored Mar 31, 2023
@bors bors bot closed this Mar 31, 2023
@bors bors bot deleted the fragment-config branch March 31, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegfriedweber @maltesander