Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a ConfigMap for the prepared logs in the logging test #422

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jun 27, 2024

Description

Use a ConfigMap for the prepared logs in the logging test

kubectl cp was used to directly copy the prepared logs into the Spark history server pod, but this fails if the pod is restarting. This pull request creates a ConfigMap with the prepared logs and mounts it into the log path of the vector container.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@siegfriedweber siegfriedweber requested a review from a team June 27, 2024 09:21
@siegfriedweber siegfriedweber self-assigned this Jun 27, 2024
@razvan razvan requested review from razvan and removed request for a team June 27, 2024 09:38
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@razvan razvan added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 3ff3dd0 Jun 27, 2024
32 checks passed
@razvan razvan deleted the test/fix-logging-test branch June 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants