Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add config maps #50

Closed
wants to merge 55 commits into from
Closed

[Merged by Bors] - Add config maps #50

wants to merge 55 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Apr 8, 2022 •
edited by razvan
Loading

Description

Make inline spark properties available via ConfigMap.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

fhennig and others added 30 commits March 29, 2022 11:50
@fhennig
removed obsolete helm chart; added spark cluster role
959c774
@fhennig
Added spark service account
24921ce
@fhennig
regenerated helm chart
60d6640
@fhennig
clippy fix
979dba8
@fhennig
clippy fix
7329f44
@fhennig
fmt fix
3da2b05
@fhennig
clippy fix
8b9720d
@razvan
main merge
cde716f
@razvan
cargo fmt --all
d97d3cf
@fhennig
Cluster Role
a64b8b9
@adwk67
added role permissions for PVCs
c176a80
@adwk67
regenerate role yamls
0710e14
@adwk67
fixed indents
408f729
@adwk67
fixed indents: manifests
c02ee47
@fhennig
Added recommended labels
cc62802
@fhennig
Merge branch 'rbac-setup' of github.com:stackabletech/spark-k8s-opera…
7d37a0e 
…tor into rbac-setup
@fhennig
Added a comment
d2f56c9
@fhennig
Changelog entry
00100f7
@adwk67
reduce pvc permissions
b483452
@adwk67
initial missing standard docs
60e6002
@adwk67
added placeholders for pvc/rbac docs
9e4b602
@adwk67
added external storage comments
fd18d0d
@adwk67
Merge branch 'main' into documentation
a1b4ce8
@adwk67
added pvc example
dd3cabb
@adwk67
lint warning
a754cc5
@adwk67
lint warning II
fc288b2
@adwk67
pv/pvc example
26cd122
@adwk67
initial RBAC page
c527606
@adwk67
Merge branch 'main' into documentation
f1c3c0d
@adwk67
rbac overview
e0f9307
@adwk67 adwk67 marked this pull request as ready for review April 12, 2022 16:03
@adwk67 adwk67 requested review from razvan and fhennig April 12, 2022 16:03
nightkr
nightkr reviewed Apr 14, 2022
View reviewed changes
docs/modules/ROOT/examples/example-configmap.yaml Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
razvan
razvan reviewed Apr 14, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but it would be nice to also add a kuttl test.

razvan
razvan approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adwk67 adwk67 removed the request for review from fhennig April 19, 2022 13:59
@adwk67
Copy link
Member Author

adwk67 commented Apr 19, 2022

Closes #35

@adwk67
Copy link
Member Author

adwk67 commented Apr 19, 2022

bors merge

bors bot pushed a commit that referenced this pull request Apr 19, 2022
@fhennig @razvan @adwk67
Add config maps (#50)
6ffe634 
## Description

Make inline spark properties available via ConfigMap.



Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@bors
Copy link

bors bot commented Apr 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add config maps [Merged by Bors] - Add config maps Apr 19, 2022
@bors bors bot closed this Apr 19, 2022
@bors bors bot deleted the add-config-maps branch April 19, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr left review comments

@razvan razvan razvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adwk67 @razvan @nightkr @fhennig