Skip to content

Commit

Permalink
adress review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
maltesander committed May 10, 2024
1 parent fb52838 commit 449ca2f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 12 deletions.
5 changes: 1 addition & 4 deletions rust/crd/src/affinity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,8 @@ mod tests {
)
]))
}),
match_label_keys: None,
mismatch_label_keys: None,
namespace_selector: None,
namespaces: None,
topology_key: "kubernetes.io/hostname".to_string(),
..PodAffinityTerm::default()
},
weight: 70
}
Expand Down
10 changes: 6 additions & 4 deletions rust/crd/src/authentication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,13 @@ mod tests {
use std::pin::Pin;

use indoc::indoc;
use stackable_operator::commons::authentication::{
oidc,
tls::{CaCert, Tls, TlsClientDetails, TlsServerVerification, TlsVerification},
use stackable_operator::{
commons::authentication::{
oidc,
tls::{CaCert, Tls, TlsClientDetails, TlsServerVerification, TlsVerification},
},
kube,
};
use stackable_operator::kube;

use super::*;

Expand Down
12 changes: 8 additions & 4 deletions rust/operator-binary/src/rbac.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
use stackable_operator::builder::meta::ObjectMetaBuilder;
use stackable_operator::k8s_openapi::api::core::v1::ServiceAccount;
use stackable_operator::k8s_openapi::api::rbac::v1::{RoleBinding, RoleRef, Subject};
use stackable_operator::kube::{Resource, ResourceExt};
use stackable_operator::{
builder::meta::ObjectMetaBuilder,
k8s_openapi::api::{
core::v1::ServiceAccount,
rbac::v1::{RoleBinding, RoleRef, Subject},
},
kube::{Resource, ResourceExt},
};

/// Obsolete: only used in the DB controller for historical reasons. Scheduled for deletion
/// once the entire DB controller is deleted as discused here: <https://github.com/stackabletech/superset-operator/issues/351>
Expand Down

0 comments on commit 449ca2f

Please sign in to comment.