Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CRD for Superset credentials #33

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Remove unused CRD for Superset credentials #33

merged 1 commit into from
Dec 3, 2021

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Dec 2, 2021 •
edited by lfrancke
Loading

Description

The CRD for the Superset credentials was not used and therefore can be removed.

Tested by stackabletech/integration-tests#36

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

@siegfriedweber siegfriedweber requested a review from a team December 2, 2021 13:15
@siegfriedweber siegfriedweber self-assigned this Dec 2, 2021
@siegfriedweber siegfriedweber merged commit 676f367 into main Dec 3, 2021
@siegfriedweber siegfriedweber deleted the remove_superset_credentials_crd branch December 3, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfrancke lfrancke lfrancke approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegfriedweber @lfrancke