[Merged by Bors] - feat: Set explicit resources on all containers #371

razvan · 2023-06-06T11:56:48Z

Part of: stackabletech/issues#394

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible
CRD changes approved
Helm chart can be installed and deployed operator works
Integration tests passed (for non trivial changes)
Options

Reviewer

Give feedback

Code contains useful comments
(Integration-)Test cases added
Documentation added or updated
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)
Options

Acceptance

Give feedback

Feature Tracker has been updated
Proper release label has been added
Options

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Raise postgres chart version.

razvan · 2023-06-12T13:09:01Z

tests successful on AKS 1.26:

--- PASS: kuttl (2081.38s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_superset-2.1.0-stackable0.0.0-dev_openshift-false (133.47s)
        --- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (141.89s)
        --- PASS: kuttl/harness/druid-connection_superset-1.5.3-stackable0.0.0-dev_openshift-false (124.13s)
        --- PASS: kuttl/harness/druid-connection_superset-2.0.1-stackable0.0.0-dev_openshift-false (182.65s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-2.1.0-stackable0.0.0-dev_openshift-false (152.84s)
        --- PASS: kuttl/harness/druid-connection_superset-1.4.2-stackable0.0.0-dev_openshift-false (121.96s)
        --- PASS: kuttl/harness/druid-connection_superset-2.1.0-stackable0.0.0-dev_openshift-false (87.09s)
        --- PASS: kuttl/harness/druid-connection_superset-1.3.2-stackable0.0.0-dev_openshift-false (87.55s)
        --- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (124.79s)
        --- PASS: kuttl/harness/logging_superset-2.0.1-stackable0.0.0-dev_openshift-false (137.06s)
        --- PASS: kuttl/harness/logging_superset-1.5.3-stackable0.0.0-dev_openshift-false (95.39s)
        --- PASS: kuttl/harness/logging_superset-1.4.2-stackable0.0.0-dev_openshift-false (119.44s)
        --- PASS: kuttl/harness/logging_superset-1.3.2-stackable0.0.0-dev_openshift-false (111.30s)
        --- PASS: kuttl/harness/resources_superset-latest-2.1.0-stackable0.0.0-dev_openshift-false (153.16s)
        --- PASS: kuttl/harness/smoke_superset-2.1.0-stackable0.0.0-dev_openshift-false (189.20s)
        --- PASS: kuttl/harness/smoke_superset-2.0.1-stackable0.0.0-dev_openshift-false (131.71s)
        --- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (103.40s)
        --- PASS: kuttl/harness/smoke_superset-1.5.3-stackable0.0.0-dev_openshift-false (144.34s)
        --- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (151.85s)
        --- PASS: kuttl/harness/smoke_superset-1.4.2-stackable0.0.0-dev_openshift-false (193.84s)
        --- PASS: kuttl/harness/smoke_superset-1.3.2-stackable0.0.0-dev_openshift-false (100.66s)
        --- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (100.32s)
        --- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (109.05s)
        --- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (116.02s)
        --- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (113.51s)
        --- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (113.02s)
        --- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (98.78s)
        --- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (115.93s)
        --- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (105.08s)
        --- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (111.62s)
        --- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (118.78s)
        --- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (159.03s)

Cargo.toml

CHANGELOG.md

Cargo.toml

rust/operator-binary/src/superset_controller.rs

rust/operator-binary/src/superset_db_controller.rs

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

Cargo.toml

Techassi · 2023-06-27T14:35:58Z

Local smoke tests succeeded:

--- PASS: kuttl (662.03s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_superset-1.3.2-stackable0.0.0-dev_openshift-false (219.65s)
        --- PASS: kuttl/harness/smoke_superset-2.0.1-stackable0.0.0-dev_openshift-false (234.02s)
        --- PASS: kuttl/harness/smoke_superset-2.1.0-stackable0.0.0-dev_openshift-false (223.77s)
        --- PASS: kuttl/harness/smoke_superset-1.5.3-stackable0.0.0-dev_openshift-false (227.65s)
        --- PASS: kuttl/harness/smoke_superset-1.4.2-stackable0.0.0-dev_openshift-false (218.58s)

sbernauer

LGTM % minor things

docs/modules/superset/pages/usage-guide/storage-resource-configuration.adoc

rust/operator-binary/src/superset_controller.rs

…guration.adoc Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

sbernauer

Thx! LGTM when tests pass

Techassi · 2023-06-29T06:47:22Z

Jenkins tests pass, see custom test run #42:

--- PASS: kuttl (1214.65s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (139.33s)
        --- PASS: kuttl/harness/druid-connection_superset-1.3.2-stackable0.0.0-dev_openshift-false (139.94s)
        --- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (148.46s)
        --- PASS: kuttl/harness/druid-connection_superset-2.1.0-stackable0.0.0-dev_openshift-false (174.56s)
        --- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (103.37s)
        --- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (127.75s)
        --- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (154.23s)
        --- PASS: kuttl/harness/druid-connection_superset-1.5.3-stackable0.0.0-dev_openshift-false (185.22s)
        --- PASS: kuttl/harness/druid-connection_superset-2.0.1-stackable0.0.0-dev_openshift-false (129.12s)
        --- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (111.37s)
        --- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (108.29s)
        --- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (157.02s)
        --- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (145.13s)
        --- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (205.20s)
        --- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (361.78s)
        --- PASS: kuttl/harness/resources_superset-latest-2.1.0-stackable0.0.0-dev_openshift-false (85.00s)
        --- PASS: kuttl/harness/smoke_superset-2.1.0-stackable0.0.0-dev_openshift-false (187.10s)
        --- PASS: kuttl/harness/logging_superset-2.0.1-stackable0.0.0-dev_openshift-false (94.21s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-2.1.0-stackable0.0.0-dev_openshift-false (178.65s)
        --- PASS: kuttl/harness/logging_superset-1.5.3-stackable0.0.0-dev_openshift-false (93.56s)
        --- PASS: kuttl/harness/logging_superset-2.1.0-stackable0.0.0-dev_openshift-false (196.23s)
        --- PASS: kuttl/harness/logging_superset-1.3.2-stackable0.0.0-dev_openshift-false (86.41s)
        --- PASS: kuttl/harness/logging_superset-1.4.2-stackable0.0.0-dev_openshift-false (91.97s)
        --- PASS: kuttl/harness/druid-connection_superset-1.4.2-stackable0.0.0-dev_openshift-false (133.98s)
        --- PASS: kuttl/harness/smoke_superset-1.5.3-stackable0.0.0-dev_openshift-false (167.44s)
        --- PASS: kuttl/harness/smoke_superset-1.3.2-stackable0.0.0-dev_openshift-false (227.11s)
        --- PASS: kuttl/harness/smoke_superset-2.0.1-stackable0.0.0-dev_openshift-false (196.96s)
        --- PASS: kuttl/harness/smoke_superset-1.4.2-stackable0.0.0-dev_openshift-false (148.35s)
        --- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (107.21s)
        --- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (110.25s)
        --- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (126.93s)
        --- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (161.31s)

Techassi · 2023-06-29T06:47:34Z

bors r+

Part of: stackabletech/issues#394 # Description *Please add a description here. This will become the commit message of the merge request later.* Co-authored-by: Techassi <git@techassi.dev>

bors · 2023-06-29T07:05:18Z

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

All tests passed

Add resource quotas to smoke tests.

0de2f36

Raise postgres chart version.

razvan mentioned this pull request Jun 6, 2023

Set explicit resources on all containers stackabletech/issues#394

Closed

razvan added 2 commits June 6, 2023 13:58

Update CHANGELOG.md

0810730

First successful smoke test

186de84

razvan requested a review from a team June 12, 2023 12:32

razvan marked this pull request as ready for review June 12, 2023 13:09

fhennig reviewed Jun 13, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Techassi self-assigned this Jun 27, 2023

Techassi added 2 commits June 27, 2023 11:08

Update operator-rs to 0.42.1, update resources, update tests

23a0e62

Add newline at EOF for '00-limit-range.yaml'

8c9e090

sbernauer changed the title ~~Smoke tests with resource quotas~~ Set explicit resources on all containers Jun 27, 2023

sbernauer requested changes Jun 27, 2023

View reviewed changes

Techassi and others added 3 commits June 27, 2023 11:23

Update CHANGELOG.md

8d6f59a

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

Add suggestions

87a973d

Fix typo in Cargo.toml

032451e

razvan commented Jun 27, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Techassi and others added 4 commits June 27, 2023 11:39

Re-add double slash hack in Cargo.toml

faf573a

Raise job container memory

9270b20

Bump operator-rs

925bd31

Merge branch 'main' into feat/resource-quotas

5d7f1e3

sbernauer changed the title ~~Set explicit resources on all containers~~ feat: Set explicit resources on all containers Jun 28, 2023

Update CRD

f3ef821

sbernauer reviewed Jun 28, 2023

View reviewed changes

docs/modules/superset/pages/usage-guide/storage-resource-configuration.adoc Outdated Show resolved Hide resolved

rust/operator-binary/src/superset_controller.rs Outdated Show resolved Hide resolved

Techassi and others added 3 commits June 28, 2023 12:17

Update docs/modules/superset/pages/usage-guide/storage-resource-confi…

64c25d0

…guration.adoc Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

Inline ResourceRequirementsBuilder in superset-controller

98953db

Merge branch 'main' into feat/resource-quotas

3953cf7

Techassi requested a review from sbernauer June 28, 2023 10:28

sbernauer approved these changes Jun 28, 2023

View reviewed changes

bors bot changed the title ~~feat: Set explicit resources on all containers~~ [Merged by Bors] - feat: Set explicit resources on all containers Jun 29, 2023

bors bot closed this Jun 29, 2023

bors bot deleted the feat/resource-quotas branch June 29, 2023 07:05

lfrancke added the release/23.7.0 label Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - feat: Set explicit resources on all containers #371

[Merged by Bors] - feat: Set explicit resources on all containers #371

razvan commented Jun 6, 2023 •

edited by lfrancke

Loading

Author

Reviewer

Acceptance

razvan commented Jun 12, 2023

Techassi commented Jun 27, 2023

sbernauer left a comment

sbernauer left a comment

Techassi commented Jun 29, 2023

Techassi commented Jun 29, 2023

bors bot commented Jun 29, 2023

[Merged by Bors] - feat: Set explicit resources on all containers #371

[Merged by Bors] - feat: Set explicit resources on all containers #371

Conversation

razvan commented Jun 6, 2023 • edited by lfrancke Loading

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

razvan commented Jun 12, 2023

Techassi commented Jun 27, 2023

sbernauer left a comment

Choose a reason for hiding this comment

sbernauer left a comment

Choose a reason for hiding this comment

Techassi commented Jun 29, 2023

Techassi commented Jun 29, 2023

bors bot commented Jun 29, 2023

razvan commented Jun 6, 2023 •

edited by lfrancke

Loading