Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SupersetDB #396

Merged
merged 13 commits into from
Aug 30, 2023
Merged

Remove SupersetDB #396

merged 13 commits into from
Aug 30, 2023

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Aug 22, 2023

Description

As discussed in #351:

  • Removed .spec.clusterConfig.loadExamplesOnInit (loading examples is not supported anymore by the operator, instead we want to document how it can be done)
  • Removed all the SupersetDB related code
  • Moved database init commands from a separate Job to the command of each Superset Pod (We can move it into an initContainer, needs discussion and probably a separate issue for that)
  • Added liveness and readiness probes (I used these values: https://github.com/apache/superset/blob/35eb66a322f7938f840778633a4aea11c7f24dce/helm/superset/values.yaml#L300-L317)
  • Changed Pod Management Policy to OrderedReady, to make sure Pods start after another and the init commands don't run in parallel
  • It's still possible that during an upgrade from e.g. 1.5.3 to 2.1.0 some Pods temporarily are on 1.5.3 while others are already on 2.1.0. I don't think that's a problem though.
  • Wait for SupersetCluster instead of SupersetDB in DruidConnection

I tested various scenarios manually (multiple replicas, different upgrade paths, also the DruidConnection stuff), everything worked as expected.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@fhennig
Copy link
Contributor

fhennig commented Aug 22, 2023

Is there also a ticket somewhere for adding instructions how to install the demo data again?

@dervoeti
Copy link
Member Author

Will create one tomorrow, we'll discuss this briefly in the Arch meeting.

@dervoeti
Copy link
Member Author

There it is: #397

@dervoeti dervoeti self-assigned this Aug 24, 2023
@dervoeti dervoeti requested a review from maltesander August 24, 2023 14:28
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just minor things. Changelog is missing.

rust/operator-binary/src/main.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/superset_controller.rs Outdated Show resolved Hide resolved
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dervoeti dervoeti added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit c20f7b9 Aug 30, 2023
@dervoeti dervoeti deleted the spike/remove-supersetdb branch August 30, 2023 09:54
@dervoeti dervoeti changed the title Spike/remove SupersetDB Remove SupersetDB Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants