-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SupersetDB #396
Remove SupersetDB #396
Conversation
…ator into spike/remove-supersetdb
Is there also a ticket somewhere for adding instructions how to install the demo data again? |
Will create one tomorrow, we'll discuss this briefly in the Arch meeting. |
There it is: #397 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just minor things. Changelog is missing.
Co-authored-by: Malte Sander <contact@maltesander.com>
…etech/superset-operator into spike/remove-supersetdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
As discussed in #351:
.spec.clusterConfig.loadExamplesOnInit
(loading examples is not supported anymore by the operator, instead we want to document how it can be done)OrderedReady
, to make sure Pods start after another and the init commands don't run in parallelSupersetCluster
instead ofSupersetDB
in DruidConnectionI tested various scenarios manually (multiple replicas, different upgrade paths, also the DruidConnection stuff), everything worked as expected.
Definition of Done Checklist
Author
Reviewer
Acceptance