Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add listener-operator where missing #425

Merged
merged 2 commits into from
Nov 20, 2023
Merged

docs: Add listener-operator where missing #425

merged 2 commits into from
Nov 20, 2023

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Nov 20, 2023 •
edited by maltesander
Loading

Description

The listener-operator is now one of the fundamental operators, along with the commons- and secret-operators, and should be mentioned accordingly everywhere.

Add changes from c50bcff#diff-2b236650ca0d74d6bb0e5931c2dd8a65e59c63637e4e3d9d89ea62b915e46e58 to the template file.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@siegfriedweber siegfriedweber self-assigned this Nov 20, 2023
@siegfriedweber siegfriedweber mentioned this pull request Nov 20, 2023
Closed
@maltesander maltesander self-requested a review November 20, 2023 11:43
maltesander
maltesander previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We do not mention dependencies here as in other operators (secret...). Maybe we add the section to be consistent?

maltesander
maltesander approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber siegfriedweber added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit 334cabe Nov 20, 2023
29 of 30 checks passed
@siegfriedweber siegfriedweber deleted the doc/add-listener-operator branch November 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@fhennig fhennig Awaiting requested review from fhennig

Assignees

@siegfriedweber siegfriedweber

Labels
area/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegfriedweber @maltesander