fix: invalid objects don't stop the reconciliation #551

razvan · 2024-10-23T15:07:57Z

Description

Part of: stackabletech/issues#211

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible
CRD changes approved
CRD documentation for all fields, following the style guide.
Helm chart can be installed and deployed operator works
Integration tests passed (for non trivial changes)
Changes need to be "offline" compatible
Options

Reviewer

Give feedback

Code contains useful comments
Code contains useful logging statements
(Integration-)Test cases added
Documentation added or updated. Follows the style guide.
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)
Options

Acceptance

Give feedback

Feature Tracker has been updated
Proper release label has been added
Roadmap has been updated
Options

rust/operator-binary/src/main.rs

Co-authored-by: Natalie Klestrup Röijezon <teo@nullable.se>

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+    let Ok(druid_connection) = &druid_connection.0 else {
+        return false;
+    };
+    druid_connection.druid_namespace().ok() == config_map.meta().namespace


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:238:59 | 238 | druid_connection.druid_namespace().ok() == config_map.meta().namespace | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 238 | druid_connection.druid_namespace().ok() == config_map.meta_mut().namespace | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+    let Ok(druid_connection) = &druid_connection.0 else {
+        return false;
+    };
+    druid_connection.druid_namespace().ok() == config_map.meta().namespace


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:238:59 | 238 | druid_connection.druid_namespace().ok() == config_map.meta().namespace | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 238 | druid_connection.druid_namespace().ok() == config_map.meta_mut().namespace | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+        return false;
+    };
+    druid_connection.druid_namespace().ok() == config_map.meta().namespace
+        && Some(druid_connection.druid_name()) == config_map.meta().name


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:239:62 | 239 | && Some(druid_connection.druid_name()) == config_map.meta().name | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 239 | && Some(druid_connection.druid_name()) == config_map.meta_mut().name | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+        return false;
+    };
+    druid_connection.druid_namespace().ok() == config_map.meta().namespace
+        && Some(druid_connection.druid_name()) == config_map.meta().name


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:239:62 | 239 | && Some(druid_connection.druid_name()) == config_map.meta().name | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 239 | && Some(druid_connection.druid_name()) == config_map.meta_mut().name | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+    let Ok(druid_connection) = &druid_connection.0 else {
+        return false;
+    };
+    druid_connection.metadata.namespace == job.meta().namespace


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:249:48 | 249 | druid_connection.metadata.namespace == job.meta().namespace | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 249 | druid_connection.metadata.namespace == job.meta_mut().namespace | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+    let Ok(druid_connection) = &druid_connection.0 else {
+        return false;
+    };
+    druid_connection.metadata.namespace == job.meta().namespace


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:249:48 | 249 | druid_connection.metadata.namespace == job.meta().namespace | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 249 | druid_connection.metadata.namespace == job.meta_mut().namespace | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+        return false;
+    };
+    druid_connection.metadata.namespace == job.meta().namespace
+        && Some(druid_connection.job_name()) == job.meta().name


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:250:53 | 250 | && Some(druid_connection.job_name()) == job.meta().name | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 250 | && Some(druid_connection.job_name()) == job.meta_mut().name | ~~~~~~~~

github-actions · 2024-10-24T12:03:27Z

rust/operator-binary/src/main.rs

+        return false;
+    };
+    druid_connection.metadata.namespace == job.meta().namespace
+        && Some(druid_connection.job_name()) == job.meta().name


🚫 [clippy] _{reported by reviewdog 🐶}

error[E0599]: no method named `meta` found for reference `&stackable_operator::kube::kube_core::DeserializeGuard` in the current scope --> rust/operator-binary/src/main.rs:250:53 | 250 | && Some(druid_connection.job_name()) == job.meta().name | ^^^^ | = help: items from traits can only be used if the trait is in scope help: trait `Resource` which provides `meta` is implemented but not in scope; perhaps you want to import it | 1 + use stackable_operator::kube::Resource; | help: there is a method `meta_mut` with a similar name | 250 | && Some(druid_connection.job_name()) == job.meta_mut().name | ~~~~~~~~

fix: invalid objects don't stop the reconciliation

3d72760

razvan self-assigned this Oct 23, 2024

razvan requested review from nightkr and a team October 23, 2024 15:08

razvan enabled auto-merge October 23, 2024 15:08

razvan mentioned this pull request Oct 23, 2024

Don't stop reconciling if one of the objects is not deserializable stackabletech/issues#211

Closed

17 tasks

nightkr reviewed Oct 24, 2024

View reviewed changes

rust/operator-binary/src/main.rs Outdated Show resolved Hide resolved

rust/operator-binary/src/main.rs Outdated Show resolved Hide resolved

rust/operator-binary/src/main.rs Outdated Show resolved Hide resolved

rust/operator-binary/src/main.rs Outdated Show resolved Hide resolved

razvan and others added 4 commits October 24, 2024 14:59

Update rust/operator-binary/src/main.rs

12d2fd8

Co-authored-by: Natalie Klestrup Röijezon <teo@nullable.se>

Update rust/operator-binary/src/main.rs

d5687fc

Co-authored-by: Natalie Klestrup Röijezon <teo@nullable.se>

Update rust/operator-binary/src/main.rs

2282732

Co-authored-by: Natalie Klestrup Röijezon <teo@nullable.se>

Update rust/operator-binary/src/main.rs

d9f0a2d

Co-authored-by: Natalie Klestrup Röijezon <teo@nullable.se>

razvan requested a review from nightkr October 24, 2024 12:00

nightkr approved these changes Oct 24, 2024

View reviewed changes

github-actions bot reviewed Oct 24, 2024

View reviewed changes

razvan added this pull request to the merge queue Oct 24, 2024

Merged via the queue into main with commit 04a3046 Oct 24, 2024
26 of 30 checks passed

razvan deleted the feature/deserializeguard branch October 24, 2024 12:06

razvan mentioned this pull request Oct 24, 2024

update usage of DeserializsedGuard refs #552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: invalid objects don't stop the reconciliation #551

fix: invalid objects don't stop the reconciliation #551

razvan commented Oct 23, 2024

Author

Reviewer

Acceptance

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

github-actions bot Oct 24, 2024

fix: invalid objects don't stop the reconciliation #551

fix: invalid objects don't stop the reconciliation #551

Conversation

razvan commented Oct 23, 2024

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot Oct 24, 2024

Choose a reason for hiding this comment