Skip to content

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Nov 2, 2023

Description

Not sure we want to point to pull requests and docs referenced in there...any opinions?

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [ ] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@maltesander maltesander requested a review from a team November 2, 2023 10:36
@maltesander maltesander self-assigned this Nov 2, 2023
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with linking a PR, but I would use a permalink for the docs when possible

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@maltesander maltesander enabled auto-merge November 2, 2023 10:50
@maltesander maltesander added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 11bd281 Nov 2, 2023
@maltesander maltesander deleted the docs/new-opa-authorizer-428 branch November 2, 2023 11:07
@lfrancke
Copy link
Member

lfrancke commented Nov 3, 2023

This is a temporary thing, right? Do we have/need a tracking issue to remove this again?

@maltesander
Copy link
Member Author

This is a temporary thing, right? Do we have/need a tracking issue to remove this again?

Yeah the 414 part (our old authorizer) can be removed once we do not support that anymore. Where do you want to track it?

@lfrancke
Copy link
Member

lfrancke commented Nov 6, 2023

I think a follow-up issue linked to this one would be good.
I can then label it with scheduled-for/next (doesn't exist yet but I can take care of that)

Could you create that issue and link it here?

@maltesander
Copy link
Member Author

#496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants