Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deps for imports in generated code #147

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

melindalu
Copy link
Contributor

@melindalu melindalu commented Mar 10, 2020

After golang/protobuf#785 go_grpc_library fails with

$ bazel build //services/example/protos:example_grpc_go_library
INFO: Analyzed target //services/example/protos:example_grpc_go_library (5 packages loaded, 186 targets configured).
INFO: Found 1 target...
ERROR: /Users/melinda/code/example/services/example/protos/BUILD.bazel:8:1: GoCompilePkg services/example/protos/darwin_amd64_stripped/example_grpc_go_library%/github.com/melindalu/example/services/example/protos.a failed (Exit 1)
compilepkg: missing strict dependencies:
	/private/var/tmp/_bazel_melinda/0181ab8bd8f9c21018c34bfa3a8cf24f/execroot/com_github_melindalu_example/bazel-out/darwin-fastbuild/bin/services/example/protos/example_grpc_go_library_pb/services/example/protos/example.pb.go: import of "google.golang.org/grpc/codes"
	/private/var/tmp/_bazel_melinda/0181ab8bd8f9c21018c34bfa3a8cf24f/execroot/com_github_melindalu_example/bazel-out/darwin-fastbuild/bin/services/example/protos/example_grpc_go_library_pb/services/example/protos/example.pb.go: import of "google.golang.org/grpc/status"
No dependencies were provided.

@melindalu melindalu closed this Mar 10, 2020
@melindalu melindalu reopened this Mar 10, 2020
@pcj pcj merged commit 8695538 into stackb:master Apr 20, 2020
@melindalu melindalu deleted the ml-add-grpc-deps branch April 20, 2020 23:26
alexeagle pushed a commit to alexeagle/rules_proto that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants