Skip to content

Conversation

Nemikolh
Copy link
Member

@Nemikolh Nemikolh commented Feb 27, 2024

This PR adds sections for Chrome and Firefox about supporting the auto-connect flow for preview in a separate tab.

It also adds to all images a width and a height to remove some of the jankiness that I'm seeing on local where if I visit /platform/webcontainers/browser-config#chrome-preview-separate-tab I was ending up on the wrong section of the page.

(seems that there's still some but looks like it's caused by the rest of the interface, not the doc page)

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for stackblitz-docs ready!

Name Link
🔨 Latest commit fb136f5
🔍 Latest deploy log https://app.netlify.com/sites/stackblitz-docs/deploys/65df35a19df8790008c736da
😎 Deploy Preview https://deploy-preview-210--stackblitz-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Dominic Elm <d3lm@users.noreply.github.com>
@Nemikolh Nemikolh requested a review from d3lm February 28, 2024 09:34
Copy link
Member

@kirjavascript kirjavascript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some optional wording suggestions that felt more natural to me

@SamVerschueren SamVerschueren merged commit 140cd48 into main Feb 28, 2024
@SamVerschueren SamVerschueren deleted the chrome-firefox-auto-connect branch February 28, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants