Skip to content

Fix performance boost regexp #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fix performance boost regexp #13

merged 1 commit into from
Feb 28, 2018

Conversation

enykeev
Copy link
Contributor

@enykeev enykeev commented Sep 12, 2017

No description provided.

@yoshuawuyts
Copy link
Contributor

Hey! Looks like this patch works; tho I'm not entirely sure what the difference is between ( and [ in this context. Could you perhaps provide a bit of background info? Thanks a lot!

@enykeev
Copy link
Contributor Author

enykeev commented Sep 14, 2017 •
edited
Loading

https://stackoverflow.com/questions/3789417/whats-the-difference-between-and-in-regular-expression-patterns gives an excellent explanation on the matter. With /[insert\-css|sheetify\/insert]/ it's nearly impossible to find a file that would not match the regexp.

@goto-bus-stop goto-bus-stop merged commit e7be824 into stackcss:master Feb 28, 2018
@goto-bus-stop
Copy link
Member

good find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enykeev @yoshuawuyts @goto-bus-stop