Max total fee

[ekzyis]

Description

This adds max base fee as a new autowithdrawal setting. This can be used to make small withdrawals possible without allowing a higher max fee rate for big withdrawals.

This setting is set to 0 for users which have autowithdrawals enabled to keep existing fee settings and not suddenly allow higher fees without their interaction.

close #1383 based on #1487

Screenshots

Additional Context

• Does subtitle of network fees make sense?
• Does hint for max base fee make sense?
• Can we expect or do we want stackers to understand the difference between max fee rate, max base fee and pathfinding?

Checklist

Are your changes backwards compatible? Please answer below:

yes, new db column added but is nullable

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

6. I checked that max fee is correctly calculated during autowithdrawal.

For frontend changes: Tested on mobile? Please answer below:

yes

Did you introduce any new environment variables? If so, call them out explicitly here:

no

[huumn]

It looks like you mean "max absolute fee" rather than "max base fee."

I think what we want is "max fee relative" and "max fee absolute" but I'm not sure that's pleb friendly.

[huumn]

Maybe "max fee rate" and "max fee total"

[huumn]

I think we also want the subtitle to say "we'll use whichever is higher" given the withdrawn amount.

[ekzyis]

Updated text. Now looks like this:

[huumn]

This probably needs to account for #1499?

[ekzyis]

This probably needs to account for #1499?

Oh, I already accounted for the new autoWithdrawMaxFeeTotal in #1499 but not for autoWithdrawThreshold. Added now!