Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Add the verbose and noParse options #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

circlecycle
Copy link

There are cases where angular code intended to be processed by webpack cannot be modified to adapt to webpack. In these cases, certain dependencies of angular.module() statements will never comply with webpack resolve rules, as is the case with angular-ui-bootstrap's builtin templates.

The major option here, noParse, allows this plugin to be configured to ignore matching dependencies either globally, or on certain modules only when the developer knows that dependency will be satisfied at runtime without help from webpack.

The second option, verbose, simply pretty prints information to the console as angular modules are discovered and their dependencies added which can be useful for beginners understanding what this plugin does.

Tests will not pass because the current version of webpack outputs a format (bundle.js) different than the ones contained in the current test. I would like to submit a pull request for that separately.

Using this plugin for an enterprise project where the codebase may not be touched, hence the interest in contributing back what it took to get a clean build of our project.

An example of the new feature is:

    new AngularWebpackPlugin({
      verbose:true,
      noParse:{
        "ui.bootstrap.tpls":[
          /^template\/.*\.html$/
        ]
      }
    })

…the AngularWebpackPlugin in webpack.config.js. noParse expects a dictionary where the keys are exact module names and the values are strings or regexes that represent dependencies that, when detected on an angular.module() definition, will be ignored. Verbose merely pretty prints angular.modules() with dependencies and skipped dependencies as they are found. noParse allows for angular code that cannot be modified for use with webpack to be successfully packaged.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant