Initial support for creating WebGL 2 contexts. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to rebase this PR on the latest? |
This support is very incomplete and only works for a bare minimum of functionality. It hasn't been tested against the WebGL 2 CTS. To create a WebGL 2 context, use the "createWebGL2Context" attribute in the creation options struct. Implementation notes: - in native code, we use a single native class for both context types - we assign enum constants dynamically, so we replace gl.ENUM with this.ENUM in the context helper functions - only adds VAOs from the set of new WebGL 2 object types This contribution is funded by https://higharc.com/
null77
force-pushed
the
webgl2-prototype
branch
from
9fe7d9d to
31bde7c
Compare
Done, looks like it's passing. |
dhritzkiv
reviewed
Mar 13, 2025
| @@ -2878,14 +2943,22 @@ class WebGLRenderingContext extends NativeWebGLRenderingContext { | |||
| data[0] = value[0] | |||
| return super.vertexAttrib4f(index | 0, +value[0], +value[1], +value[2], +value[3]) | |||
| } | |||
|
|
|||
| _isWebGL2 () { | |||
There was a problem hiding this comment.
Note to self: this is a good candidate for a getter
| @@ -5,6 +5,10 @@ class WebGLTextureUnit { | |||
| this._mode = 0 | |||
| this._bind2D = null | |||
| this._bindCube = null | |||
| if (ctx._isWebGL2) { | |||
There was a problem hiding this comment.
because this is not a getter (yet), I suspect that this is always truthy
| @@ -776,6 +836,15 @@ class WebGLRenderingContext extends NativeWebGLRenderingContext { | |||
| return webGlTexture | |||
| } | |||
|
|
|||
| createVertexArray () { | |||
| // TODO: do not expose VAO methods in WebGL 1 | |||
There was a problem hiding this comment.
To resolve this TODO, should these method be declared only on WebGL2RenderingContext?
Or will it be tricky for devs to deal with the return type of createContext and having to check if the context is a WebGL2RenderingContext
| } | ||
|
|
||
| setError (error) { | ||
| // if (error !== 0) { |
|
TODO for myself: update README with experimental WebGL 2 support section |
This was
linked to
issues
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support is very incomplete and only works for a bare minimum of functionality. It hasn't been tested against the WebGL 2 CTS. To create a WebGL 2 context, use the "createWebGL2Context" attribute in the creation options struct.
Implementation notes:
This contribution is funded by https://higharc.com/
@dhritzkiv we're currently using this branch in our headless testing, and I can verify it works for the subset of functionality we have in our CI. At the moment this is the last of the work I had planned, but we'll probably need to add more support as we extend our testing coverage. One of the major hurdles would be migrating the gl-conformance library to run on top of the most recent CTS, and adding WebGL 2 CTS support.