Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Deprecated V1 options #240

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Removing Deprecated V1 options #240

merged 2 commits into from
Jan 26, 2024

Conversation

Bwvolleyball
Copy link
Contributor

Description of the change

Remove Deprecated v1 opts.

replace me

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

ISSUE-ID

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Bwvolleyball Bwvolleyball requested a review from a team as a code owner January 26, 2024 19:51
kcberg
kcberg previously approved these changes Jan 26, 2024
View reviewed changes
Copy link

@kcberg kcberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

d-co-white
d-co-white previously approved these changes Jan 26, 2024
View reviewed changes
clamey
clamey previously approved these changes Jan 26, 2024
View reviewed changes
@d-co-white d-co-white dismissed stale reviews from clamey, kcberg, and themself via cc1d13b January 26, 2024 20:29
@Bwvolleyball Bwvolleyball merged commit e11ccfe into main Jan 26, 2024
12 checks passed
@Bwvolleyball Bwvolleyball deleted the bugfix/removing-deprecated-v1-opts branch January 26, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-co-white d-co-white d-co-white approved these changes

@kcberg kcberg kcberg left review comments

@clamey clamey clamey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bwvolleyball @clamey @kcberg @d-co-white