Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking change in StackHawk 3.9.9 #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix breaking change in StackHawk 3.9.9 #19

wants to merge 2 commits into from

Conversation

nickfrollo
Copy link

Description of the change

Fix breaking change in StackHawk docker image of renamed working directory

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

ISSUE-ID

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@nickfrollo nickfrollo requested a review from a team as a code owner July 8, 2024 03:40
kcberg
kcberg previously approved these changes Jul 11, 2024
View reviewed changes
@Bwvolleyball
Copy link

Going to close and re-open to see if I can trigger the builds!

@Bwvolleyball Bwvolleyball reopened this Jul 12, 2024
@Bwvolleyball
Copy link

once more with feeling.

@Bwvolleyball Bwvolleyball reopened this Jul 12, 2024
@Bwvolleyball Bwvolleyball force-pushed the feature/fix-working-dir-name branch 8 times, most recently from 45d74ad to a1242a6 Compare July 12, 2024 20:35
@Bwvolleyball Bwvolleyball force-pushed the feature/fix-working-dir-name branch from a1242a6 to d747b5b Compare July 12, 2024 20:35
@Bwvolleyball
Copy link

Looks like our orb build has rotted quite a bit, slowly starting to work through the upgrade to circleci/orb-tools@12.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcberg kcberg kcberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickfrollo @Bwvolleyball @kcberg