Add squid role #401
Merged
Add squid role #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Image build (RL9 only): https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/9614023233 |
Collaborator
Author
sd109
previously approved these changes
Jun 27, 2024
Member
sd109
left a comment
sd109
left a comment
There was a problem hiding this comment.
Nice work! LGTM, just some very minor nit picking comments.
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
sd109
approved these changes
Jun 27, 2024
MaxBed4d
pushed a commit
that referenced
this pull request
Oct 15, 2024
* add squid role + config * make systemd proxy config idempotent (and clearer) * fix defaults for squid/builder * bump CI image * fix squid cache dir definition error * Fix squid README nits Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com> * Fix squid README nits Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com> * Fix squid README nits Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com> * Fix squid README nits Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com> * make proxy default to squid port --------- Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squidrole to allow nodes without direct access to download packages etc.proxyrole defaults to set proxy automatically ifsquidenabled.proxyrole.Squid here is from the dnf packages and is not containerised. This avoids a dependency on the
podmanrole, which otherwise might mean only the control node could run squid (as the control node requires podman). Given the stability of squid this seems a reasonable trade-off.