- 
                Notifications
    
You must be signed in to change notification settings  - Fork 37
 
Added CI to create PRs to bump to latest Ark timestamps #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            wtripp180901
  wants to merge
  59
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
feat/auto-bump-timestamps
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    sjpb
  
              
              requested changes
              
                  
                    Dec 19, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion on slack re. simplifying things so we're not defining repo URLs in 3x places.
Also needs to
a) kick off an image build in the PR - and not run the stackhpc.yml workflow
- Could do this by changing that workflow to not run on branch names like e.g. auto/ and setting that branch for the PR
b) make a commit to the PR to change environments/.stackhpc/terraform/cluster* vars to the new image - then run the stackhpc workflow 
OR
- do the image build on the branch
 - update ../cluster* definition
 - THEN open the PR (which runs stackhpc.yml)
 
c3a36d0    to
    29ad8db      
    Compare
  
    29ad8db    to
    333ac6e      
    Compare
  
    56cb15f    to
    02e3de6      
    Compare
  
    02e3de6    to
    bf14c8a      
    Compare
  
    cbc518f    to
    0863a9a      
    Compare
  
    66d8775    to
    37eb61b      
    Compare
  
    58446ac    to
    57e2d7f      
    Compare
  
    | 
           Todo: 
 Todo after review but before merging: 
  | 
    
e436d5d    to
    7e8fd62      
    Compare
  
    7e8fd62    to
    9ff34cb      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Added a nightly workflow which will check the URLs defined in
appliances_repo_timestamp_sourcesfor newer timestamps, updateappliances_repo_timestampsand create a PR if any timestamps have been updated