Replace whitespace in NHC mount checks #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
New PR created as per wiki to let our CI run. |
sjpb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @JenksJ:
When mounting a cifs mount that included white space in the source path the slurm NHC (Node Health Check) fails. This resulted in all the nodes being put into drain. The slurm warning output was something like:
NHC: check_fs_mount:
/mnt/gen_epi mounted from //10.10.10.10/3.040Projects/sequencing040list
(should match //10.10.10.10/3. Projects/sequencing list)
Ansible mount in /etc/fstab formats white space as ASCII code \040 including the .
/etc/fstab (and the CIFS kernel client) does not accept pre-escaped \040 in the src path. So the replace(' ', '\040') was added to ansible/roles/nhc/templates/nhc.conf.j2 as a quick fix.