Skip to content

Conversation

@sjpb
Copy link
Collaborator

@sjpb sjpb commented Oct 17, 2025

Moving baremetal nodes between e.g. production and staging is often necessary to test changes due to the limted number of them available. If these have fixed IPs specified via ip_addresses this change allows the IPs to be left while removing the actual nodes, which makes this move easier as the IP configuration can remain in source.

Also allows e.g. predefining expected IPs before fully expanding a cluster.

E.g. with this PR this configuration passes validation but creates no nodes:

# environments/staging/tofu/main.tf:
module "cluster" {
  ...
  compute = {
    gpu = {
      nodes = []
      ip_addresses = {
        mynet = ["192.168.0.14", "192.168.0.15"]
      }
    }
  }
}

@sjpb sjpb marked this pull request as ready for review October 17, 2025 14:09
@sjpb sjpb requested a review from a team as a code owner October 17, 2025 14:09
Copy link
Member

@bertiethorpe bertiethorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit b540bfd into main Oct 21, 2025
39 of 43 checks passed
@sjpb sjpb deleted the feat/ip-no-node branch October 21, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants