Skip to content

Commit

Permalink
Use Azimuth UI schema for integer constraint
Browse files Browse the repository at this point in the history
  • Loading branch information
sd109 committed Jul 12, 2024
1 parent 43848b0 commit c78922b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions chart/azimuth-ui.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ controls:
type: MirrorControl
path: /huggingface/model
visuallyHidden: true
# Azimuth UI doesn't handle json type ["integer","null"]
# properly so we allow type "string" in JSON schema then
# constrain to (optional) integer here.
/api/modelMaxContextLength:
type: IntegerControl
required: false

sortOrder:
- /huggingface/model
Expand Down
4 changes: 2 additions & 2 deletions chart/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"type": "object",
"properties": {
"modelMaxContextLength": {
"type": ["integer", "null"],
"type": "string",
"title": "Model Context Length",
"description": "An override for the maximum context length to use if the model's default is not suitable."
},
Expand All @@ -106,7 +106,7 @@
"properties": {
"version": {
"type": "string",
"title": "vLLM version override",
"title": "Backend vLLM version",
"description": "The vLLM version to use as a backend. Must be a version tag from [this list](https://github.com/vllm-project/vllm/tags)",
"default": "v0.4.3"
}
Expand Down

0 comments on commit c78922b

Please sign in to comment.