Fix the tagging policy engine #193
Merged
+348
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service tagging policy engine should consider the parent resource or the upper parent resource project ID when checking the policies against the caller project ID. Before this patch, as introduced in [1], the target was incorrectly populated with the caller project ID instead of using the resource ID. [1]https://review.opendev.org/c/openstack/neutron/+/896509/13/neutron/extensions/tagging.py OSSA-2024-005 CVE-2024-53916 Closes-Bug: #2088986 Change-Id: Id7d0c8e7ba37993b1084519d05e7e2eac095b81b (cherry picked from commit fb75d3c)
|
Yoinked from #192 Tests all passed: |
priteau
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service tagging policy engine should consider the parent resource or the upper parent resource project ID when checking the policies against the caller project ID.
Before this patch, as introduced in [1], the target was incorrectly populated with the caller project ID instead of using the resource ID.
[1]https://review.opendev.org/c/openstack/neutron/+/896509/13/neutron/extensions/tagging.py
OSSA-2024-005 CVE-2024-53916
Closes-Bug: #2088986
Change-Id: Id7d0c8e7ba37993b1084519d05e7e2eac095b81b (cherry picked from commit fb75d3c)