Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector plugins are broken in Ussuri #11

Closed
dougszumski opened this issue Nov 12, 2020 · 2 comments · Fixed by #12
Closed

Inspector plugins are broken in Ussuri #11

dougszumski opened this issue Nov 12, 2020 · 2 comments · Fixed by #12
Assignees
@dougszumski

Comments

@dougszumski
Copy link
Member

https://review.opendev.org/#/c/672179/ replaced ironic client with the openstacksdk which has caused a breakage. Specifically:

2020-11-12 14:27:25.683 6 ERROR ironic_inspector.node_cache [-] [node: d043bfb2-8913-4f91-aef3-8c8b51383770 state processing] Processing the error event becau
se of an exception <class 'TypeError'>: get_client() got an unexpected keyword argument 'api_version' raised by ironic_inspector.process._process_node        
2020-11-12 14:27:25.683 6 INFO ironic_inspector.node_cache [-] [node: d043bfb2-8913-4f91-aef3-8c8b51383770 state processing] Updating node state: processing -
-> error                                                                                                                                                      
2020-11-12 14:27:25.705 6 ERROR ironic_inspector.process [-] Unexpected exception during processing: TypeError: get_client() got an unexpected keyword argumen
t 'api_version'
@dougszumski dougszumski self-assigned this Nov 12, 2020
dougszumski added a commit that referenced this issue Nov 12, 2020
@dougszumski
Fix Ussuri bug caused by Ironic Inspector switch to OpenStackSDK
0abda30 
In Ussuri Ironic Inspector switched to the OpenStackSDK. Passing
the API microversion is no longer supported when calling get_client.
The default microversion works fine on Ussuri, so there is no longer
a need to specify it.

Resolves #11
@markgoddard
Copy link

Semi-related: Ironic adopted the BasePhysnetHook class from this repo in Ussuri: https://review.opendev.org/#/q/BasePhysnetHook. I had thought they were going to take the system_name_physnet and ib_physnet plugins too, but looks like that was forgotten.

@markgoddard
Copy link

The plugin base plugin in inspector does not use the client directly, so switching to that should fix the issue.

markgoddard added a commit that referenced this issue May 24, 2022
@markgoddard
Use base_physnet plugin in Ironic Inspector
f9adbf0 
Since Ussuri, Ironic Inspector contains a base_physnet plugin that was
based on the one in this repository. This change switches to use that
plugin and deletes the one in this repository.

This also fixes an issue caused by a change in the Ironic client:

    Unexpected exception during processing: TypeError: get_client() got
    an unexpected keyword argument 'api_version'

Fixes: #11
@markgoddard markgoddard mentioned this issue May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougszumski dougszumski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use base_physnet plugin in Ironic Inspector stackhpc/stackhpc-inspector-plugins
2 participants
@dougszumski @markgoddard