Skip to content

INFRA-908 Change grafana plugin install logic #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: stackhpc/2025.1
Choose a base branch
from
Open

INFRA-908 Change grafana plugin install logic #991

wants to merge 4 commits into from
+13 −3

Conversation

technowhizz
Copy link
Contributor

This PR contains the changes needed to make use of https://review.opendev.org/c/openstack/kolla/+/913184 (if and when it gets merged).

This PR should only be merged if the above patch is in our kolla.

@technowhizz technowhizz self-assigned this Mar 14, 2024
@dougszumski
Copy link
Member

@technowhizz , please could you placate the naysayers on the upstream PR? It would be good to finish this.

@Alex-Welsh
Copy link
Member

@technowhizz the upstream PR has been merged. Is this one ready to be merged?

@technowhizz technowhizz changed the title Change grafana plugin install logic INFRA-908 Change grafana plugin install logic Dec 13, 2024
@technowhizz
Copy link
Contributor Author

@Alex-Welsh Once this PR is merged stackhpc/kolla#368 we can go ahead and merge this

@technowhizz technowhizz changed the base branch from stackhpc/2023.1 to stackhpc/2024.1 December 13, 2024 16:27
@technowhizz technowhizz force-pushed the grafana-plugin-logic branch 2 times, most recently from 4b976eb to 712e0b0 Compare December 13, 2024 18:29
dougszumski
dougszumski previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should come from Kolla after backport merges

@technowhizz technowhizz marked this pull request as ready for review January 21, 2025 13:34
@technowhizz technowhizz requested a review from a team as a code owner January 21, 2025 13:34
@technowhizz technowhizz enabled auto-merge January 21, 2025 13:34
@Alex-Welsh
Copy link
Member

@Alex-Welsh Once this PR is merged stackhpc/kolla#368 we can go ahead and merge this

stackhpc/kolla#368 has merged, anything you want to add to this PR?

technowhizz and others added 4 commits September 23, 2025 10:36
@technowhizz @jovial @Alex-Welsh
Change grafana plugin install logic
5d052bd 
Changing the way in which we specify grafana plugins to install. This is
due to a change upstream which now allows plugins to be installed in an
additive method instead of replacing the upstream default plugins [1].

[1] https://review.opendev.org/c/openstack/kolla/+/913184

Co-authored-by: Will Szumski <will@stackhpc.com>
@technowhizz @Alex-Welsh
Remove angular plugins from grafana
9e73667
@technowhizz @Alex-Welsh
Bump grafana image to remove angular plugins
bb27d2b
@technowhizz @Alex-Welsh
Add releasenote
7ca3e8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougszumski dougszumski dougszumski left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@technowhizz technowhizz

Labels
size: s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technowhizz @dougszumski @Alex-Welsh