Skip to content

RT-297: StackifyLib #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2017
Merged

RT-297: StackifyLib #53

merged 3 commits into from
Oct 19, 2017

Conversation

strvmarv
Copy link
Contributor

  • Internal logging improvements
  • Consistency check compile constants

* Internal logging improvements
* Consistency check compile constants
@strvmarv strvmarv requested a review from eric-martin October 10, 2017 20:31
}
}



public static void Log(string message, bool logAnyways = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this call into the Log method below and handle the null ex case there. Duplicated code.

Copy link
Contributor

@eric-martin eric-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment below.

* Duplicate code
* Increment versions for nuget deployment
@strvmarv strvmarv merged commit ed40f4c into master Oct 19, 2017
@strvmarv strvmarv deleted the bug/RT-297 branch October 19, 2017 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants