Skip to content

Add make variable IS_DEV to control oci image suffix #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2025
Merged

Add make variable IS_DEV to control oci image suffix #24

merged 2 commits into from
Oct 21, 2025

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Oct 20, 2025 •
edited
Loading

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

If set, container images will be named *-dev

  • ghcr.io/stackitcloud/cloud-provider-stackit/cloud-controller-manager-dev
  • ghcr.io/stackitcloud/cloud-provider-stackit/stackit-csi-plugin-dev

Related work items:

Special notes for your reviewer:

Breaking changes:

@xoxys
Copy link
Member Author

xoxys commented Oct 20, 2025

/hold

@ske-prow ske-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2025
@ske-prow ske-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2025
@xoxys
Copy link
Member Author

xoxys commented Oct 21, 2025

/unhold

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@xoxys xoxys requested a review from a team October 21, 2025 06:38
@xoxys xoxys added the kind/enhancement Enhancement, improvement, extension label Oct 21, 2025
@ske-prow ske-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 21, 2025
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@ske-prow
Copy link

ske-prow bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robinschneider

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow
Copy link

ske-prow bot commented Oct 21, 2025

LGTM label has been added.

Git tree hash: 4cefe313c4092bef64ef763ace4722917cb33aee

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@ske-prow ske-prow bot merged commit d5314ff into main Oct 21, 2025
3 checks passed
@ske-prow ske-prow bot deleted the dev-tag branch October 21, 2025 07:05
@xoxys
Copy link
Member Author

xoxys commented Oct 22, 2025

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33

@stackit-ske
Copy link

@xoxys: new pull request created: #45

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Oct 22, 2025
Merged
@stackit-ske
Copy link

@xoxys: new pull request created: #46

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Oct 22, 2025
Merged
@stackit-ske
Copy link

@xoxys: new pull request created: #47

In response to this:

/cherry-pick release-v1.31
/cherry-pick release-v1.32
/cherry-pick release-v1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robinschneider robinschneider robinschneider approved these changes

Assignees

@robinschneider robinschneider

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xoxys @stackit-ske @robinschneider