Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation that triggers a volume recreation #13

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

maboehm
Copy link
Collaborator

@maboehm maboehm commented Jun 3, 2024

How to categorize this PR?
/kind enhancement

What this PR does / why we need it:
Adds a new annotationdruid.gardener.cloud/recreate-volumes that triggers a recreation of all PVCs.
Details are documented in recreate-volumes.md

Which issue(s) this PR fixes:
ADO#628815

Special notes for your reviewer:
I tried to keep the changes to existing files / functions minimal. Main injection points are:

  • setting annotations in the main reconcile() function (+ an additional check)
  • optionally adding a task to delete all old PVCs
  • setting the template.Annotations accordingly

You can check a running version of the change on ond-bba32c

@maboehm

This comment was marked as resolved.

@maboehm
Copy link
Collaborator Author

maboehm commented Jun 3, 2024

I don't understand why etcd-events behaves that way. But since we wont be recreating it (it does not use gardener.cloud-fast storage class), I think its fine. I added validation to only allow volume recreation on etcds that have backups enabled.

@ske-prow ske-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 10, 2024
@maboehm maboehm added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jun 11, 2024
@maboehm
Copy link
Collaborator Author

maboehm commented Jun 11, 2024

/test pull-etcd-druid-images-dev

@maboehm
Copy link
Collaborator Author

maboehm commented Jun 12, 2024

I think I fixed the flake, the second PVC now has the suffix -1 and PVCs should be cleaned up correctly

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

LGTM label has been added.

Git tree hash: 5939e74c88a2cbdb8792ab68b8608bbb723edc1f

@ske-prow
Copy link

ske-prow bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@ske-prow ske-prow bot merged commit 1527c8e into ske-v0.22 Jun 13, 2024
3 checks passed
@maboehm maboehm deleted the recreate-volumes branch June 14, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants