-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation that triggers a volume recreation #13
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I don't understand why etcd-events behaves that way. But since we wont be recreating it (it does not use |
9e99185
to
9941fbc
Compare
/test pull-etcd-druid-images-dev |
9941fbc
to
c5a0689
Compare
c5a0689
to
3fe980d
Compare
I think I fixed the flake, the second PVC now has the suffix |
LGTM label has been added. Git tree hash: 5939e74c88a2cbdb8792ab68b8608bbb723edc1f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Adds a new annotation
druid.gardener.cloud/recreate-volumes
that triggers a recreation of all PVCs.Details are documented in
recreate-volumes.md
Which issue(s) this PR fixes:
ADO#628815
Special notes for your reviewer:
I tried to keep the changes to existing files / functions minimal. Main injection points are:
reconcile()
function (+ an additional check)template.Annotations
accordinglyYou can check a running version of the change on
ond-bba32c