Skip to content

feat(goreleaser): add completion to homebrew installation #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

marceljk
Copy link
Contributor

@marceljk marceljk commented Apr 7, 2025

Description

relates to stackitcloud/homebrew-tap#3

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

Copy link
Member

@rubenhoenle rubenhoenle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested somehow?

Copy link

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenhoenle I tested the generate_completions_from_executable as part of

stackitcloud/homebrew-tap#3 - I added the commands to test it.

@marceljk
Copy link
Contributor Author

marceljk commented Apr 8, 2025

To get the generated Formula, you need to run $ goreleaser release --skip=publish,validate --clean. But you need to remove some steps temporary from the .goreleaser.yaml, because they depends on some credentials or try to publish something. I described it more in our internal channel.
And with the generated Formula, the test from @jkroepke can be executed

@marceljk marceljk merged commit 39c1fe0 into main Apr 9, 2025
3 checks passed
@marceljk marceljk deleted the feat/brew-installation-completion branch April 9, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants