Improve keepalived handling during updates #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dergeberl
commented
Jun 14, 2023
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller_test.go
Show resolved
Hide resolved
timebertt
requested changes
Jun 14, 2023
controllers/yawol-controller/loadbalancer/loadbalancer_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancer/loadbalancer_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller.go
Outdated
Show resolved
Hide resolved
…when another keepalived with higher priority is available
…t is a keepalived master
dergeberl
force-pushed
the
feature/keepalivedDuringUpdate
branch
from
954a416
to
935cc9c
Compare
…fter 15 min to not block update
timebertt
reviewed
Jun 14, 2023
timebertt
previously approved these changes
Jun 14, 2023
timebertt
approved these changes
Jun 14, 2023
Kumm-Kai
approved these changes
Jun 14, 2023
einfachnuralex
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it can take some seconds until the new keepalived is taking over, because the old LoadbalancerMachine gets deleted and we relay on keepalived to quickly taking over.
This consists of multible parts:
ContainsKeepalivedMastercondition on loadbalancerset to identify if there is a keepalived master in this setContainsKeepalivedMastercondition on the lbs is true for 2 min