⚠️ Switch to pflag #407
Merged
⚠️ Switch to pflag #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai and
maboehm
as code owners
You mean [...] which is not supported by flag? |
maboehm
approved these changes
Sep 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the command line flag handling to use
pflaginstead offlag.This is a preparation for upcoming PRs, where list flags should be used, which is not supported by
flag.This is a breaking change because yawol components no longer accept flags with a single dash, but only with double dashes.
The helm chart is adapted accordingly, so users of the chart should not be required to adapt to this change.
Note: I decided to defer the chart version bump to a later PR so that we can release this together with the PR where we make use of
pflag.